ferdi2go/Meeting-Mixer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Code-Quality] DRY: Datums-/Helper-Duplikate in utils.js zentralisieren #12

New Issue
Closed
opened 2026-06-03 14:10:02 +02:00 by ferdi2go · 1 comment
ferdi2go commented 2026-06-03 14:10:02 +02:00
Owner
Copy Link
Copy Source

Schweregrad: MEDIUM

Dateien: ISO-Bau js/calendar.js:122,141,180,190; Weekday inline js/calendar.js:181,191; DD.MM.YYYY js/excel.js:25, js/history.js:127, js/calendar.js:313; Name-Map js/calendar.js:151, js/excel.js:14, js/history.js:105

Problem: toISO/getWeekday existieren in js/algorithm.js, werden aber nicht exportiert/wiederverwendet; mehrfache Reimplementierungen.

Fix: Gemeinsame Helfer (toISO, getWeekday, formatDateDE, buildNameMap) in js/utils.js ziehen und überall importieren.

**Schweregrad:** MEDIUM **Dateien:** ISO-Bau `js/calendar.js:122,141,180,190`; Weekday inline `js/calendar.js:181,191`; `DD.MM.YYYY` `js/excel.js:25`, `js/history.js:127`, `js/calendar.js:313`; Name-Map `js/calendar.js:151`, `js/excel.js:14`, `js/history.js:105` **Problem:** `toISO`/`getWeekday` existieren in `js/algorithm.js`, werden aber nicht exportiert/wiederverwendet; mehrfache Reimplementierungen. **Fix:** Gemeinsame Helfer (`toISO`, `getWeekday`, `formatDateDE`, `buildNameMap`) in `js/utils.js` ziehen und überall importieren.
ferdi2go added the code-qualityseverity/medium labels 2026-06-03 14:10:02 +02:00
ferdi2go commented 2026-06-03 15:01:28 +02:00
Author
Owner
Copy Link
Copy Source

Behoben in fd98708: neues js/utils.js mit toISO, monthPrefix, getWeekday, formatDateDE, buildNameMap. algorithm.js, calendar.js, excel.js, history.js importieren diese statt ISO-Bau, Weekday-Logik, DD.MM.YYYY-Formatierung und id→name-Map mehrfach inline zu reimplementieren. Inkl. tests/utils.test.mjs (auch in npm test verdrahtet).

Behoben in `fd98708`: neues `js/utils.js` mit `toISO`, `monthPrefix`, `getWeekday`, `formatDateDE`, `buildNameMap`. `algorithm.js`, `calendar.js`, `excel.js`, `history.js` importieren diese statt ISO-Bau, Weekday-Logik, DD.MM.YYYY-Formatierung und id→name-Map mehrfach inline zu reimplementieren. Inkl. `tests/utils.test.mjs` (auch in `npm test` verdrahtet).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Barrierefreiheit
 bug
Logik-/Korrektheitsfehler
 code-quality
Code-Qualitaet / Refactoring
 docs
Dokumentation
 performance
Performance
 security
Sicherheit / Hardening
 severity/high
Hoher Schweregrad
 severity/low
Niedriger Schweregrad
 severity/medium
Mittlerer Schweregrad
 testing
Tests
No Label code-quality severity/medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ferdi2go
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ferdi2go/Meeting-Mixer#12
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?